Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve opam file doc #8850

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Oct 5, 2023

I'm not exactly sure what makes dune "opinionated", but whatever it is, I don't think it is our main feature. I've therefore swapped "opinionated" for "composable" which seems like a better thing to advertise.

I've also changed the wording in the synopsis of the opam file, including "composable" there too so that readers know what we mean.

cc @emillon @christinerose

Edit: I've undone the "opinionated -> composable" change.

@Alizter Alizter added the docs Documentation improvements label Oct 5, 2023
@emillon emillon added the requires-team-discussion This topic requires a team discussion label Oct 5, 2023
Signed-off-by: Ali Caglayan <[email protected]>
@Alizter Alizter force-pushed the ps/branch/doc__improve_opam_file_doc branch from e4412b6 to ecd66ca Compare October 26, 2023 18:40
@Alizter
Copy link
Collaborator Author

Alizter commented Oct 26, 2023

@emillon I've now removed the synopsis change as discussed in the meeting.

@Alizter Alizter removed the requires-team-discussion This topic requires a team discussion label Oct 26, 2023
@emillon emillon merged commit d0e0efb into ocaml:main Nov 7, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants