-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix learn-ocaml build -j 2
issue
#416
base: master
Are you sure you want to change the base?
Conversation
…atch guard Aim: mitigate a TOC/TOU race condition which occurs when Learnocaml_process_exercise_repository.n_processes > 1, triggered by a command such as "learn-ocaml build -j 2". This isn't the only possible fix/workaround, just a concise one relying on error handling.
… a Lwt.catch guard" This reverts commit 8698753.
Instead of tweaking Lwt_utils.mkdir_p, we add a call to this function for the "www/static" directory before running the parallel build jobs. MINOR-DRAWBACK: "www/static" is created even if there is no exercise!
Hi all, I've tried 2 different fixes in this PR (tweak Both fix the issue mentioned in However, the issue is more pervasive than what I thought at first sight: despite this potential fix,
So, I'm going to postpone this for the time being − fixing this parallel build issue would be nice, but will require more investigation in (FTR, the outputs above mention "0.12" but the tested version was obviously the commits from this PR; |
This PR is intended to Reproduce and Fix #414