Simple pp output #524
Closed
Simple pp output #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricoferris
force-pushed
the
pp-simple
branch
from
3aa0a6b
to
e227b7a
Compare
|
I think the "1,117" lines removed really speaks volumes for adding something like this to the driver. It saved me a lot of time debugging the migrations :)) |
NathanReb
reviewed
Sep 24, 2024
There was a problem hiding this comment.
The output is incredibly easier to read and more compact, I wasn't expecting that much of an improvement over the sexp representation!
As you mentioned, I'll try to see if we can simply change the output of -dparsetree without having to introduce a new flag but if it turns out we can't this would be a worthy addition to the driver!
NathanReb
reviewed
Sep 24, 2024
With -pp-simple drivers can print a simplified AST. This is useful for debugging purposes. It is similar to the ppxlib-pp-ast tool packaged with ppx-tools, but it is not configurable. Signed-off-by: Patrick Ferris <[email protected]>
Co-authored-by: Nathan Rebours <[email protected]> Signed-off-by: Patrick Ferris <[email protected]>
patricoferris
force-pushed
the
pp-simple
branch
from
e227b7a
to
0ea8c52
Compare
patricoferris
requested review from
ceastlund,
panglesd and
pitag-ha
as code owners
|
Closing in favour of #530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an idea to share based on #517 -- changing the migrations
run.tto use this was very useful for debugging more issues with the 5.2 AST bump cc @NathanReb.We discussed (offline) the possibility of changing
-dparsetreeto output thePp_astoutput. We would need to understand the downstream use-cases of-dparsetreebefore doing that.