Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Context_free.map_top_down's embed_errors arg optional #468

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Make Context_free.map_top_down's embed_errors arg optional #468

merged 2 commits into from
Feb 2, 2024

Commits on Feb 2, 2024

  1. Make Context_free.map_top_down embed_errors arg optional 

    This extra argument that was added in ocaml-ppx#453 caused breakage
in `ocsigen-i18n` that was using `Context_free.map_top_down`.
Although it's undocumented, this function is still part of the public
API. Adding an extra optional argument is not strictly speaking
non-breaking but is good enough of an effort considering the status
of this function and in particular, the fact that it only has a single
public external user for which it prevents breakage.

Signed-off-by: Nathan Rebours <[email protected]>
    @NathanReb
    NathanReb committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    6084599 View commit details
    Browse the repository at this point in the history

  2. Update CHANGES.md 

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Nathan Rebours <[email protected]>
    @NathanReb @github-actions
    NathanReb and github-actions[bot] committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    9887aa4 View commit details
    Browse the repository at this point in the history