Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.1 migrations: Add tests for generative functors #432

Merged
merged 9 commits into from
Sep 19, 2023
Merged

5.1 migrations: Add tests for generative functors #432

merged 9 commits into from
Sep 19, 2023

Commits on Sep 19, 2023

  1. Make the migration tests deterministic 

    Signed-off-by: Sonja Heinze <[email protected]>
    @pitag-ha @panglesd
    pitag-ha authored and panglesd committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    1539ee3 View commit details
    Browse the repository at this point in the history

  2. 5.1 migrations: Add tests for generative functors 

    Signed-off-by: Sonja Heinze <[email protected]>
    @pitag-ha @panglesd
    pitag-ha authored and panglesd committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    a07aaf6 View commit details
    Browse the repository at this point in the history

  3. Fix generative functor location in 501 -> 500 migration 

    Signed-off-by: Paul-Elliot <[email protected]>
    @panglesd
    panglesd committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b8e54cf View commit details
    Browse the repository at this point in the history

  4. Migration: Use an attribute for generative functor migration 

    Two 501 constructs are represented the same way in 500. One of them
raise a warning.
During the 501 -> 500 -> 501 migration, we need to be careful to keep
the warning where it was originally.
We use attributes to remember which 501 representation to choose. The
reserved namespace is "ppxlib.migration".

Signed-off-by: Paul-Elliot <[email protected]>
    @panglesd
    panglesd committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    049d1f3 View commit details
    Browse the repository at this point in the history

  5. test is now identical between 510 and earlier 

    Signed-off-by: Paul-Elliot <[email protected]>
    @panglesd
    panglesd committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    4c2ca50 View commit details
    Browse the repository at this point in the history

  6. 501<->500 migration: review comments 

    Signed-off-by: Paul-Elliot <[email protected]>
    @panglesd
    panglesd committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    af6dc07 View commit details
    Browse the repository at this point in the history

  7. 501<->500 migration: changelog entry 

    Signed-off-by: Paul-Elliot <[email protected]>
    @panglesd
    panglesd committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    d99bf41 View commit details
    Browse the repository at this point in the history

  8. 501<->500 migrations: adding a test with attributes 

    Signed-off-by: Paul-Elliot <[email protected]>
    @panglesd
    panglesd committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    92089b3 View commit details
    Browse the repository at this point in the history

  9. formatting 

    Signed-off-by: Paul-Elliot <[email protected]>
    @panglesd
    panglesd committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    89eb948 View commit details
    Browse the repository at this point in the history