pop_opt, peek, peek_opt functions for queue
#92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrm
commented
Sep 7, 2023
Comment on lines
+51
to
+61
| let b = Backoff.create () in | ||
| let rec loop () = | ||
| let old_head = Atomic.get head in | ||
| match Atomic.get old_head with | ||
| | Nil -> raise Empty | ||
| | Next (value, next) when Atomic.compare_and_set head old_head next -> value | ||
| | _ -> | ||
| Backoff.once b; | ||
| loop () | ||
| in | ||
| loop () |
There was a problem hiding this comment.
This is the same function as pop_opt except for very small changes. Should I use [@inline] and a generic pop function ?
src_lockfree/spsc_queue.ml
Outdated
Comment on lines
51
to
55
| let[@inline] try_push t element = | ||
| try | ||
| push t element; | ||
| true | ||
| with Full -> false |
There was a problem hiding this comment.
Here I try the [@inline]. But I don't think this is the right way to use it. Any help will be welcomed.
Sudha247
reviewed
Nov 2, 2023
|
|
||
| @raise Empty if [q] is empty. *) | ||
|
|
||
| val pop_opt : 'a t -> 'a option |
There was a problem hiding this comment.
Function name is not edited in the line below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames and adds functions to the single consumer single producer queue, the michael-scott queue, the treiber stack and the multiple producer single consumer queue.
popis renamedpop_optpopraisesEmptyif the queue is emptypeekandpeek_opthave been added as well (except for the stack)Other notes :
peekfunctions, as it seems useless (it is useful mostly with a single consumer).clean_untilfunction as it was no atomic.TODO :
Rename,poptopop_optfor relaxed-queuepoptopop_optfor the work-stealing dequepopandpop_optbe almost copy-paste function or should we use theinlinekeyword (see comment in code)