Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rwlock #341

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Add Rwlock #341

merged 1 commit into from
Jan 26, 2025

Conversation

polytypic
Copy link
Collaborator

@polytypic polytypic commented Jan 9, 2025 •
edited
Loading

This PR adds a low overhead Rwlock, with an associated Condition variable, using the Awaitable abstraction.

For future work:

  • Experiment with alternatives to prevent writer starvation. The simple approach of just immediately making readers wait when there is a writer waiting decreases performance.

@polytypic polytypic force-pushed the add-rwlock branch 30 times, most recently from 998fd03 to 8b16144 Compare January 14, 2025 10:09
@polytypic polytypic force-pushed the add-rwlock branch 8 times, most recently from aa5722b to cae451a Compare January 25, 2025 08:48
@polytypic polytypic changed the title Add Rwlock and Lock Add Rwlock Jan 25, 2025
@polytypic polytypic force-pushed the add-rwlock branch 11 times, most recently from 0e28768 to ad7855f Compare January 26, 2025 20:20
@polytypic polytypic marked this pull request as ready for review January 26, 2025 21:49
@polytypic polytypic force-pushed the add-rwlock branch 5 times, most recently from 146693e to abae135 Compare January 26, 2025 22:43
@polytypic polytypic merged commit 224dc6a into main Jan 26, 2025
6 checks passed
@polytypic polytypic deleted the add-rwlock branch January 26, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmid jmid jmid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polytypic @jmid