Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lin bytes adjustments #516

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Lin bytes adjustments #516

merged 3 commits into from
Jan 15, 2025

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Jan 15, 2025

Looking at the Lin Bytes test I noticed an embarrasing oversight: it was using the uniform int generators.

  • The first commit thus adjusts them to use small ones - meaning we start triggering counterexamples - and thus turning the test into a negative one. Bytes is unsafe to use in parallel after all 🤷
  • The second commit reduces the Thread count to 250, like, e.g., the similar Stack Thread test
  • The third commit adds Bytes.set - another unexpected oversight 😬

(In fairness the STM Bytes tests are free from both of the above oversights)

Fixes #515

@jmid
Copy link
Collaborator Author

jmid commented Jan 15, 2025

CI summary: all 34 workflows passed.
Merging...

@jmid jmid merged commit 2d348a5 into main Jan 15, 2025
34 checks passed
@jmid jmid deleted the lin-bytes-adjustments branch January 15, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long runtime in Lin Bytes test with Thread on Cygwin
1 participant