Fix single location updates to be linearizable and tweak internals #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polytypic
force-pushed
the
tweak-attempts
branch
from
5248c73 to
06780c8
Compare
polytypic
force-pushed
the
tweak-attempts
branch
from
06780c8 to
47e5994
Compare
polytypic
force-pushed
the
tweak-attempts
branch
from
47e5994 to
d55e965
Compare
polytypic
force-pushed
the
tweak-attempts
branch
12 times, most recently
from
bc3a5f7 to
87c7f69
Compare
polytypic
changed the title
eval to be linearizable
polytypic
force-pushed
the
tweak-attempts
branch
5 times, most recently
from
1c7542e to
d9c5e01
Compare
polytypic
changed the title
eval to be linearizable
polytypic
changed the title
Internal `eval` operation didn't properly wait for a transaction operating on the location to be finished before updating the location. This also tweaks the internal descriptor representation to be slightly more compact.
polytypic
force-pushed
the
tweak-attempts
branch
from
d9c5e01 to
6652afa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks the internal descriptor representation to be slightly more compact.
This also fixes single location updates to be linearizable with respect to multi-location updates. In case of single-location updates, an internal
evaloperation didn't properly wait for a transaction operating on the location to be finished before updating the location. This was revealed by theAccumulatorSTM test.