Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Command/Thunk.hs to nix-thunk package #946

Merged
merged 10 commits into from
Aug 10, 2022
Merged

Conversation

romefeller
Copy link
Contributor

Include nix-thunk package to enhance thunking tools.

I have:

  • Based work on latest develop branch
  • Followed the contribution guide
  • Looked for lint in my changes with hlint . (lint found code you did not write can be left alone)
  • Run the test suite: $(nix-build -A selftest --no-out-link)
  • Updated the changelog
  • (Optional) Run CI tests locally: nix-build release.nix -A build.x86_64-linux --no-out-link (or x86_64-darwin on macOS)

@plt-amy
Copy link
Contributor

plt-amy commented Jul 25, 2022

This is blocked on obsidiansystems/cli-nix#3 ATM which is blocked on a new release of cli-extras

@plt-amy plt-amy force-pushed the ago@nix-thunk branch 3 times, most recently from 1fbde5d to 21d2f63 Compare August 4, 2022 00:54
@plt-amy
Copy link
Contributor

plt-amy commented Aug 4, 2022

The force pushes above are because I accidentally ran the self-test commands in the obelisk directory so we had two commits from Obelisk Selftest. That was embarrassing. This upcoming one is a rebase

@plt-amy plt-amy marked this pull request as ready for review August 4, 2022 16:39
Copy link
Collaborator

@madeline-os madeline-os left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested; some administrative stuff I am putting on you :3

haskell-overlays/misc-deps.nix Show resolved Hide resolved
haskell-overlays/misc-deps.nix Show resolved Hide resolved
lib/command/src/Obelisk/App.hs Show resolved Hide resolved
lib/command/src/Obelisk/Command.hs Show resolved Hide resolved
@madeline-os madeline-os merged commit e3991de into develop Aug 10, 2022
@alexfmpe
Copy link
Contributor

Something changed in this PR that changed the 'clear console on code recompilation' behavior of ob run - noticed this while running ob run on the skeleton on current develop.
The new behavior is present on the commit which acted as merge for this PR, but not in its mainline parent, 17d0277

Old
old
New
new

@alexfmpe
Copy link
Contributor

ob shell seems to have been broken by this change. After this PR, ob shell doesn't actually drop me into a nix shell anymore.

madeline-os added a commit that referenced this pull request Aug 14, 2022
This was caused by #946 which accidentally replaced a use of
`runProcess_` with `runProc`. Similarly named, but different behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants