Split utility functions out from default.nix #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madeline-os
force-pushed
the
mh-split-lib
branch
2 times, most recently
from
c83dc7a
to
d160c3f
Compare
nix-thunk has two consumers: those who want to build the tool as such, and those who want to use its nix functions to manipulate thunks. The utility nix functions have been split out into `lib.nix`.
madeline-os
force-pushed
the
mh-split-lib
branch
from
d160c3f
to
fe75967
Compare
|
Should we move the deprecated functions too? I think so, though it is nice for |
Ericson2314
reviewed
Aug 22, 2022
| inherit (import ./dep/gitignore.nix { inherit (pkgs) lib; }) gitignoreSource; | ||
| lib = pkgs.callPackage ./lib.nix { | ||
| inherit gitignoreSource; | ||
| inherit (pkgs) fetchgitPrivate; |
There was a problem hiding this comment.
yea, idk why. i know fetchgitPrivate has since been removed, but it should still show up w/ callPackage on our checkout. I wanted to look further into this.
Ericson2314
reviewed
Aug 22, 2022
Co-authored-by: John Ericson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nix-thunk has two consumers: those who want to build the tool as such,
and those who want to use its nix functions to manipulate thunks. The
latter have been split out into
lib.nix.See #16