-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use github actions/workflows to build plugin assets (main.js
& manifest.json
)
#68
base: master
Are you sure you want to change the base?
Conversation
main.js
& manifest.json
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that I understand the value of uploading the build artifacts to GitHub action artifacts. Automating a full release seems more in line with what the Obsidian team asks for releasing so I opened #72
If you think there is something missing from that action that yours has let me know and I'll gladly add it
Well, as there was no CI (to be clear I'm not an expert here;)) but wanted to share it as this could be a starting point to automate. How about closing this one and adding to your PR create of artifacts (line 32-38 on my PR) as this is useful for tests on mobile (maybe with a retention period if required)? |
Good call! Having the artifacts from build would be useful for mobile. Would you like to fork https://github.com/Ebonsignori/obsidian-sample-plugin/tree/master and make a commit or would you like me to add it to my branch? |
Please just add it to your branch ;) |
Done! |
Closed in favor of #72 |
Reopeining as #72 still doesn't handle that. |
Make usage of GitHub Actions to build plugin (after push) and produce plugin zip artifacts containinig
main.js
&manifest.json
as on screenshot below: