Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github actions/workflows to build plugin assets (main.js & manifest.json) #68

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mwoz123
Copy link

@mwoz123 mwoz123 commented Aug 9, 2023

Make usage of GitHub Actions to build plugin (after push) and produce plugin zip artifacts containinig

  • main.js &
  • manifest.json

as on screenshot below:
image

@mwoz123 mwoz123 closed this Aug 9, 2023
@mwoz123 mwoz123 changed the title Use github actions/workflows to build plugin Use github actions/workflows to build plugin assets (main.js & manifest.json) Aug 13, 2023
@mwoz123 mwoz123 reopened this Aug 13, 2023
Copy link

@Ebonsignori Ebonsignori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that I understand the value of uploading the build artifacts to GitHub action artifacts. Automating a full release seems more in line with what the Obsidian team asks for releasing so I opened #72

If you think there is something missing from that action that yours has let me know and I'll gladly add it

.github/workflows/node.js.yml Outdated Show resolved Hide resolved
@mwoz123
Copy link
Author

mwoz123 commented Aug 28, 2023

Well, as there was no CI (to be clear I'm not an expert here;)) but wanted to share it as this could be a starting point to automate.

How about closing this one and adding to your PR create of artifacts (line 32-38 on my PR) as this is useful for tests on mobile (maybe with a retention period if required)?

@Ebonsignori
Copy link

Good call! Having the artifacts from build would be useful for mobile.

Would you like to fork https://github.com/Ebonsignori/obsidian-sample-plugin/tree/master and make a commit or would you like me to add it to my branch?

@mwoz123
Copy link
Author

mwoz123 commented Aug 28, 2023

Please just add it to your branch ;)

@Ebonsignori
Copy link

Done!

@mwoz123
Copy link
Author

mwoz123 commented Sep 8, 2023

Closed in favor of #72

@mwoz123 mwoz123 closed this Sep 8, 2023
@mwoz123
Copy link
Author

mwoz123 commented Oct 29, 2023

Reopeining as #72 still doesn't handle that.

@mwoz123 mwoz123 reopened this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants