Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ignoreDeletionMarksDelay based on deleteDelay #61

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions api/v1alpha1/observatorium_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,9 @@ type StoreSpec struct {
// ServiceMonitor enables deploying a service monitor for the Thanos Stores.
// +optional
ServiceMonitor bool `json:"serviceMonitor,omitempty"`
// Duration after which the blocks marked for deletion will be filtered out while fetching blocks.
// +optional
IgnoreDeletionMarksDelay string `json:"ignoreDeletionMarksDelay,omitempty"`
}

// StoreCacheSpec describes configuration for Store Memcached
Expand Down Expand Up @@ -368,6 +371,9 @@ type CompactSpec struct {
// ServiceMonitor enables deploying a service monitor for the Thanos Compactors.
// +optional
ServiceMonitor bool `json:"serviceMonitor,omitempty"`
// Time before a block marked for deletion is deleted from object storage.
// +optional
DeleteDelay string `json:"deleteDelay,omitempty"`
}

type VolumeClaimTemplate struct {
Expand Down
8 changes: 8 additions & 0 deletions manifests/crds/core.observatorium.io_observatoria.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1069,6 +1069,10 @@ spec:
compact:
description: Thanos CompactSpec
properties:
deleteDelay:
description: Time before a block marked for deletion is deleted
from object storage.
type: string
enableDownsampling:
description: EnableDownsampling enables downsampling.
type: boolean
Expand Down Expand Up @@ -2390,6 +2394,10 @@ spec:
description: Version of Memcached image to be deployed.
type: string
type: object
ignoreDeletionMarksDelay:
description: Duration after which the blocks marked for deletion
will be filtered out while fetching blocks.
type: string
image:
description: Thanos image
type: string
Expand Down