Make styles overridable to support different font sizes #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,7 +76,7 @@ const LargeButton = ({ | |||
| <Icon name={iconName} size={theme.icon.size.large} color={iconColor} /> | |||
| </View> | |||
| )} | |||
| <Text style={[styles.title, textStyle]}>{title}</Text> | |||
| <Text style={[styles.title, titleStyle, textStyle]}>{title}</Text> | |||
There was a problem hiding this comment.
Nu kan de text style niet overschreven worden, is dat expres?
There was a problem hiding this comment.
Ja.textStyle, buttonStyle en iconColor horen bij elkaar en definiëren de kleurstelling van de button. Ik beschouw textStyle voor de tekst van de button dan ook als een gegeven. Ik zie ook geen use case voor het kunnen overrulen van enkel de tekstkleur.
SjaakSchilperoort
force-pushed
the
feature/use-larger-font-sizes
branch
from
2112e11 to
44526f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for https://github.com/observation/app/issues/634