Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map relations to RO ids to be used in OWL translation. #125

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

balhoff
Copy link
Member

@balhoff balhoff commented Nov 16, 2022

This will make EMAPA more compatible with other OBO ontologies, by using relations from RO in its OWL file. This also eliminates problematic relation IRIs that don't resolve (see INCATools/ubergraph#102).

@matentzn
Copy link

I would very much love to see this PR accepted!

@tfhayamizu
Copy link
Contributor

@balhoff
Sorry but it is not quite clear to me what this merge would entail.
Specifically, what changes would be made to the EMAPA file itself,
and what effect would this have on the OBO formatted file that our database uses?

@balhoff
Copy link
Member Author

balhoff commented Apr 5, 2023

Hi @tfhayamizu, it would just add these xrefs to the OBO file: https://github.com/obophenotype/mouse-anatomy-ontology/pull/125/files

I wouldn't expect that to have much, if any, impact on your database, unless you're using an OWL parser.

@cmungall
Copy link
Member

It would be great to have this merged. I can guarantee it won't break anything on the MGI side. This will vastly improve how EMAPA looks in browsers that follow standards like OLS (right now EMAPA looks like a flat list which is not a good advert for your work!). I think bioportal too (can't check right now, it's down).

I suspect this will also improve things on the Alliance side as well, if the new curation tool and ontology browser is following standards.

Definitely for GO too

@matentzn
Copy link

I think someone might have to send an email to Terry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants