Display warning if crypto locking callbacks were not set

oatpp · Nov 22, 2020 · 02a94f6 · 02a94f6
1 parent 21f88cf
commit 02a94f6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/oatpp-openssl/client/ConnectionProvider.cpp b/src/oatpp-openssl/client/ConnectionProvider.cpp
@@ -42,8 +42,8 @@ ConnectionProvider::ConnectionProvider(const std::shared_ptr<Config>& config,
   setProperty(PROPERTY_HOST, streamProvider->getProperty(PROPERTY_HOST).toString());
   setProperty(PROPERTY_PORT, streamProvider->getProperty(PROPERTY_PORT).toString());
 
-  auto calback = CRYPTO_get_locking_callback();
-  if(!calback) {
+  auto callback = CRYPTO_get_locking_callback();
+  if(!callback) {
     OATPP_LOGD("[oatpp::openssl::client::ConnectionProvider::ConnectionProvider()]",
                "WARNING. openssl. CRYPTO_set_locking_callback is NOT set. "
                "This can cause problems using openssl in multithreaded environment! "

diff --git a/src/oatpp-openssl/server/ConnectionProvider.cpp b/src/oatpp-openssl/server/ConnectionProvider.cpp
@@ -39,6 +39,15 @@ ConnectionProvider::ConnectionProvider(const std::shared_ptr<Config>& config,
   setProperty(PROPERTY_HOST, streamProvider->getProperty(PROPERTY_HOST).toString());
   setProperty(PROPERTY_PORT, streamProvider->getProperty(PROPERTY_PORT).toString());
 
+  auto callback = CRYPTO_get_locking_callback();
+  if(!callback) {
+    OATPP_LOGD("[oatpp::openssl::server::ConnectionProvider::ConnectionProvider()]",
+               "WARNING. openssl. CRYPTO_set_locking_callback is NOT set. "
+               "This can cause problems using openssl in multithreaded environment! "
+               "Please call oatpp::openssl::Callbacks::setDefaultCallbacks() or "
+               "consider setting custom locking_callback.");
+  }
+
   instantiateTLSServer();
 
 }