Fix extracting translations #2119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: - redux was shared between persistent popup (can request USB permissions) and default popup - persistent popup listed ledger accounts into store - when reopening default popup listed accounts were kept - when reopening default popup after clearing listed accounts: all steps repeat After: - persistent popup requests permissions - this gives permissions to default popup too - when reopening default popup: use new permissions to list accounts from ledger
Ledger doesn't even need to be unlocked to grant USB access.
This makes it clearer what user should interact with.
Improves UX after ConnectDevice popup closes and user has to re-open the normal popup to continue the flow.
Deployed to Cloudflare Pages
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected] |
lukaw3d
force-pushed
the
lw/fix-translations
branch
from
05d2021 to
f0d89d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #2118
Fixes 0032df5