fix(gas): gas price oracle improvements #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
reviewed
Feb 5, 2024
gas/backend.go
Outdated
| return | ||
| } | ||
| g.trackPrice(lastTxPrice) | ||
|
|
||
| g.trackPrice(medTxPrice) |
There was a problem hiding this comment.
Should an epsilon be added here still? Otherwise if the queue is full of transactions with gas price X and the median gas price is also X, your transaction is not likely to make it into the next block? Ideally one would look into the current txqueue as well (to estimate where your transaction would be), but until that is not there, it would be better to still add a small epsilon as long as the blocks are full?
ptrus
force-pushed
the
ptrus/fix/gas-price-oracle
branch
2 times, most recently
from
201c92e to
9aed169
Compare
kostko
approved these changes
Feb 5, 2024
Gas price oracle heuristics are updated to return better gas price estimates for `eth_gasPrice` queries. Instead of returning the minimum gas price from the recent blocks, the maximum of the median gas price from recent full blocks is returned. Additionally the gas oracle parameters are now configurable, and the defaults are lowered to better detect full blocks.
ptrus
force-pushed
the
ptrus/fix/gas-price-oracle
branch
from
9aed169 to
9787497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gas price oracle heuristics are updated to return better gas price estimates for the
eth_gasPricequeries. Instead of returning the minimum gas price from the recent blocks, the maximum of the median gas price from recent full blocks is returned. Additionally the gas oracle parameters are now configurable, and the defaults are lowered to better detect full blocks.