Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tokenizer factory to support plugin custom tokenizer (7484) #444

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Add tokenizer factory to support plugin custom tokenizer (7484) #444

merged 2 commits into from
Nov 24, 2023

Conversation

rui-mo
Copy link
Collaborator

@rui-mo rui-mo commented Nov 22, 2023 •
edited
Loading

48886bd affects below unit test. Revert it and use customized tokenizer registered from Gluten.

200 - velox_type_test (Failed)
212 - velox_dwio_common_test (Failed)
247 - velox_dwrf_e2e_filter_test (Failed)
262 - velox_parquet_e2e_filter_test (Failed)
284 - velox_hive_connector_test (Failed)
288 - velox_exec_test (Failed)

@rui-mo rui-mo mentioned this pull request Nov 22, 2023
Merged
@rui-mo rui-mo merged commit 9b4d5af into oap-project:update Nov 24, 2023
4 checks passed
@rui-mo
Copy link
Collaborator Author

rui-mo commented Nov 24, 2023

cc @JkSelf

JkSelf pushed a commit to JkSelf/velox that referenced this pull request Nov 24, 2023
@rui-mo @JkSelf
Add tokenizer factory to support plugin custom tokenizer (7484) (oap-…
b805785 
…project#444)

* Revert "Fix subfield separator"

This reverts commit 48886bd.

* Add tokenizer factory to support plugin custom tokenizer (7484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rui-mo