hotfix: Fix -Wpessimizing-move in TypeWithId.cpp

oap-project · Apr 18, 2024 · e23f701 · e23f701
1 parent 8657ebf
commit e23f701
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/velox/dwio/common/TypeWithId.cpp b/velox/dwio/common/TypeWithId.cpp
@@ -86,7 +86,7 @@ std::unique_ptr<TypeWithId> TypeWithId::duplicate(bool nameAsLowerCase) const {
   std::vector<std::unique_ptr<TypeWithId>> children;
   children.reserve(children_.size());
   for (const auto& child : children_) {
-    children.emplace_back(std::move(child->duplicate(nameAsLowerCase)));
+    children.emplace_back(child->duplicate(nameAsLowerCase));
   }
   return std::make_unique<TypeWithId>(
       nameAsLowerCase ? adjustNameAsLowerCase(type_) : type_,