Revert "Disable check for an compatibility issue with Spark3.2"

This reverts commit 2bb887e.
oap-project · Feb 4, 2024 · bf07fed · bf07fed
1 parent 5a29a19
commit bf07fed
Showing 1 changed file with 10 additions and 13 deletions.
diff --git a/velox/functions/sparksql/specialforms/DecimalRound.cpp b/velox/functions/sparksql/specialforms/DecimalRound.cpp
@@ -37,19 +37,16 @@ class DecimalRoundFunction : public exec::VectorFunction {
         inputScale_(inputScale),
         resultPrecision_(resultPrecision),
         resultScale_(resultScale) {
-    // const auto [p, s] =
-    // DecimalRoundCallToSpecialForm::getResultPrecisionScale(
-    //     inputPrecision, inputScale, scale);
-    // VELOX_USER_CHECK_EQ(
-    //     p,
-    //     resultPrecision,
-    //     "The result precision of decimal_round is inconsistent with Spark
-    //     expected.");
-    // VELOX_USER_CHECK_EQ(
-    //     s,
-    //     resultScale,
-    //     "The result scale of decimal_round is inconsistent with Spark
-    //     expected.");
+    const auto [p, s] = DecimalRoundCallToSpecialForm::getResultPrecisionScale(
+        inputPrecision, inputScale, scale);
+    VELOX_USER_CHECK_EQ(
+        p,
+        resultPrecision,
+        "The result precision of decimal_round is inconsistent with Spark expected.");
+    VELOX_USER_CHECK_EQ(
+        s,
+        resultScale,
+        "The result scale of decimal_round is inconsistent with Spark expected.");
 
     // Decide the rescale factor of divide and multiply when rounding to a
     // negative scale.