Revert "fix UT castDecimalToDecimal and varcharToDecimal (#449)" (#450)

This reverts commit d16ea4e.
oap-project · Nov 27, 2023 · 7efd16f · 7efd16f
1 parent d16ea4e
commit 7efd16f
Showing 1 changed file with 1 addition and 11 deletions.
diff --git a/velox/type/DecimalUtil.h b/velox/type/DecimalUtil.h
@@ -175,17 +175,7 @@ class DecimalUtil {
     }
     // Check overflow.
     if (!valueInPrecisionRange(rescaledValue, toPrecision) || isOverflow) {
-      if (throwIfOverflow) {
-        VELOX_USER_FAIL(
-            "Cannot cast DECIMAL '{}' to DECIMAL({}, {})",
-            DecimalUtil::toString(
-                inputValue, DECIMAL(fromPrecision, fromScale)),
-            toPrecision,
-            toScale);
-      } else {
-        isOverflow = true;
-        return std::nullopt;
-      }
+      return std::nullopt;
     }
     return static_cast<TOutput>(rescaledValue);
   }