Skip to content

Commit

Permalink
fixup
Browse files Browse the repository at this point in the history
  • Loading branch information
zhztheplayer committed Nov 11, 2024
1 parent f9cf941 commit 5e37fb4
Showing 1 changed file with 12 additions and 10 deletions.
22 changes: 12 additions & 10 deletions velox/exec/Task.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -604,15 +604,17 @@ bool Task::supportSerialExecutionMode() const {
return false;
}

std::vector<std::unique_ptr<DriverFactory>> driverFactories;
LocalPlanner::plan(
planFragment_, nullptr, &driverFactories, queryCtx_->queryConfig(), 1);

for (const auto& factory : driverFactories) {
if (!factory->supportsSerialExecution()) {
return false;
}
}
// PoC
// std::vector<std::unique_ptr<DriverFactory>> driverFactories;
// LocalPlanner::plan(
// planFragment_, nullptr, &driverFactories, queryCtx_->queryConfig(),
// 1);
//
// for (const auto& factory : driverFactories) {
// if (!factory->supportsSerialExecution()) {
// return false;
// }
// }

return true;
}
Expand Down Expand Up @@ -1887,7 +1889,7 @@ template <class TBridgeType, typename MemberType>
std::shared_ptr<TBridgeType> Task::getJoinBridgeInternalLocked(
uint32_t splitGroupId,
const core::PlanNodeId& planNodeId,
MemberType SplitGroupState::*bridges_member) {
MemberType SplitGroupState::* bridges_member) {
const auto& splitGroupState = splitGroupStates_[splitGroupId];

auto it = (splitGroupState.*bridges_member).find(planNodeId);
Expand Down

0 comments on commit 5e37fb4

Please sign in to comment.