This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
[SQL-DS-CACHE-124] [POAE7-1133] Fix failed query in TPCDS #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aggregate case(sum/average), it may return a double type rather than long/decimal, so add a dump work around. 2) fix count node null issue
iyupeng
approved these changes
May 26, 2021
|
Will merge this one and add more fix in later PRs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
q9: fix count null issue
q44: UnscaledValue will convert to return type to double
q54: fix push down case.
Note: for q44, there are still some issues and the result is not correct.
How was this patch tested?
Manual test