WIP: Do not fork actor execution with snactor fixture #408
+23
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously running an actor within a test caused the test to be executed in a forked process and when it was executing the actor the actor was also being executed in another forked process. This patch is removing the latter fork from being done to allow easier mocking and testing. Signed-off-by: Vinzenz Feenstra <[email protected]>
vinzenz
force-pushed
the
pytest_mockability_support_for_actors
branch
from
744fe8e
to
6ccdb74
Compare
vmojzis
added a commit
to vmojzis/leapp-repository
that referenced
this pull request
Jun 12, 2019
vmojzis
added a commit
to vmojzis/leapp-repository
that referenced
this pull request
Jun 13, 2019
vmojzis
added a commit
to vmojzis/leapp-repository
that referenced
this pull request
Jun 14, 2019
vmojzis
added a commit
to vmojzis/leapp-repository
that referenced
this pull request
Jun 17, 2019
vmojzis
added a commit
to vmojzis/leapp-repository
that referenced
this pull request
Jun 27, 2019
vmojzis
added a commit
to vmojzis/leapp-repository
that referenced
this pull request
Jun 27, 2019
vmojzis
added a commit
to vmojzis/leapp-repository
that referenced
this pull request
Jun 27, 2019
vmojzis
added a commit
to vmojzis/leapp-repository
that referenced
this pull request
Jun 27, 2019
vmojzis
added a commit
to vmojzis/leapp-repository
that referenced
this pull request
Jul 3, 2019
vmojzis
added a commit
to vmojzis/leapp-repository
that referenced
this pull request
Jul 4, 2019
vmojzis
added a commit
to vmojzis/leapp-repository
that referenced
this pull request
Jul 4, 2019
vmojzis
added a commit
to vmojzis/leapp-repository
that referenced
this pull request
Aug 13, 2019
fernflower
pushed a commit
to oamg/leapp-repository
that referenced
this pull request
Aug 14, 2019
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines, pass tests and linter checks before it can be merged. If you want to re-run tests or request review, you can use following commands as a comment:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously running an actor within a test caused the test to be executed
in a forked process and when it was executing the actor the actor was
also being executed in another forked process.
This patch is removing the latter fork from being done to allow easier
mocking and testing.
Signed-off-by: Vinzenz Feenstra [email protected]