Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip checking files under .../directory-hash/ dir #1297

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

pirat89
Copy link
Member

@pirat89 pirat89 commented Sep 25, 2024

  • The main reason for this change is to improve performance and reduce flood of logs for the content that does not seem to be important to check for the upgrade process.

The directory has been relatively recently added to ca-certificates rpm on EL 9+ systems mostly to improve performance of OpenSSL and the content does not seem to be important for the IPU process. The high number of files takes too much time to evaluate and causes flood of logs that are not important.

This is updated solution that we drop originally: 60f500e

Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

Copy link

Based on your Packit configuration the settings of the @oamg/leapp Copr project would need to be updated as follows:

field old value new value
bootstrap on default

Packit was unable to update the settings above as it is missing admin permissions on the @oamg/leapp Copr project.

To fix this you can do one of the following:

  • Grant Packit admin permissions on the @oamg/leapp Copr project on the permissions page.
  • Change the above Copr project settings manually on the settings page to match the Packit configuration.
  • Update the Packit configuration to match the Copr project settings.

Please retrigger the build, once the issue above is fixed.

@pirat89
Copy link
Member Author

pirat89 commented Sep 25, 2024

The original solution checked the relative path of each file (one by one) instead of the directory. Seems to me that skipping the whole directory in this case it's a better option.

@pirat89
Copy link
Member Author

pirat89 commented Sep 25, 2024

/packit copr-build

@pirat89 pirat89 added enhancement New feature or request and removed enhancement New feature or request labels Sep 25, 2024
@pirat89 pirat89 added this to the 8.10/9.6 milestone Oct 25, 2024
* The main reason for this change is to improve performance and
reduce flood of logs for the content that does not seem to be important
to check for the upgrade process.

The directory has been relatively recently added to ca-certificates
rpm on EL 9+ systems mostly to improve performance of OpenSSL and
the content does not seem to be important for the IPU process.
The high number of files takes too much time to evaluate and causes
flood of logs that are not important.

This is updated solution that we drop originally: 60f500e
@pirat89 pirat89 force-pushed the start-to-skip-directory-hash-again branch from 7dc7355 to 87013d2 Compare October 29, 2024 14:28
@pirat89 pirat89 marked this pull request as ready for review October 29, 2024 14:29
@pirat89 pirat89 requested a review from a team October 29, 2024 14:30
@pirat89
Copy link
Member Author

pirat89 commented Oct 29, 2024

@oamg/developers review please. the IPU 7 - 8 are failing due to test issue, the 8.10 -> 9.5 failed due to infra issue most likely.

@Rezney Rezney merged commit a147938 into oamg:main Oct 30, 2024
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants