Feat/findings level #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Waltlova <[email protected]>
update schema update tests Signed-off-by: Andrea Waltlova <[email protected]>
andywaltlova
commented
Apr 12, 2024
| ) | ||
| assert output.findings_level == 7 if "error" in groups else 5 | ||
| else: # high, medium, low and info priorities | ||
| # TODO: how about low, medium and high severity? Upgrade can proceed in those cases but should findings level change? |
andywaltlova
commented
Apr 12, 2024
| @@ -95,3 +88,6 @@ def test_gather_report_files_not_exist(mock_exists): | |||
| assert output.report != "" | |||
| assert output.report_json != "" | |||
| assert output.message != "" | |||
|
|
|||
| # TODO: Should it be different when we for some reason can't find the report files? | |||
| assert output.findings_level == 1 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces new
findings_levelparam in script output.TBD on exact values, related issue.