Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1124] Refactor applock to have a more robust API. #979

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Make PID file close explicit (needed for file locking).

04c7e3e
Select commit
Loading
Failed to load commit list.
Open

[RHELC-1124] Refactor applock to have a more robust API. #979

Make PID file close explicit (needed for file locking).
04c7e3e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 11, 2024 in 1s

95.48% (+0.00%) compared to f992a1d

View this Pull Request on Codecov

95.48% (+0.00%) compared to f992a1d

Details

Codecov Report

Attention: Patch coverage is 83.33333% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 95.48%. Comparing base (f992a1d) to head (04c7e3e).
Report is 5 commits behind head on main.

❗ Current head 04c7e3e differs from pull request most recent head 5f3aa7e. Consider uploading reports for the commit 5f3aa7e to get more accurate results

Files Patch % Lines
convert2rhel/applock.py 83.33% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #979   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files          51       51           
  Lines        4627     4654   +27     
  Branches      820      829    +9     
=======================================
+ Hits         4418     4444   +26     
- Misses        134      137    +3     
+ Partials       75       73    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.