Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed state.fetch() behaviour in regards to custom token contracts #1853

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Fixed state.fetch() behaviour in regards to custom token contracts #1853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e1cdd3
Fixed fetch() behaviour in regards to custom token contracts
rpanic Oct 7, 2024
d75cf6c
Update CHANGELOG.md
Trivo25 Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,14 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

### Added

- Added `verifyEthers` method to verify Ethereum signatures using the EIP-191 message hashing standard https://github.com/o1-labs/o1js/pull/1815
- Added `verifyEthers` method to verify Ethereum signatures using the EIP-191 message hashing standard. https://github.com/o1-labs/o1js/pull/1815
- Added `fromEthers` method for parsing and converting Ethereum public keys into `ForeignCurve` points, supporting both compressed and uncompressed formats.
- Added `fromHex` method for converting hexadecimal strings into `ForeignCurve` points.

### Fixes

- Fix incorrect behavior of optional proving for zkPrograms where `myProgram.setProofsEnabled(false)` wouldn't work when called before `myProgram.compile()` https://github.com/o1-labs/o1js/pull/1827
- Fix incorrect behavior of optional proving for zkPrograms where `myProgram.setProofsEnabled(false)` wouldn't work when called before `myProgram.compile()`. https://github.com/o1-labs/o1js/pull/1827
- Fix incorrect behavior of `state.fetch()` for custom token contracts. [@rpanic](https://github.com/rpanic) https://github.com/o1-labs/o1js/pull/1853

## [1.7.0](https://github.com/o1-labs/o1js/compare/d6abf1d97...5006e4f) - 2024-09-04

Expand Down
5 changes: 3 additions & 2 deletions src/lib/mina/state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,13 +362,14 @@ function createState<T>(defaultValue?: T): InternalStateType<T> {

let layout = getLayoutPosition(this._contract);
let address: PublicKey = this._contract.instance.address;
let tokenId: Field = this._contract.instance.tokenId;
let account: Account | undefined;
if (networkConfig.minaEndpoint === '') {
account = Mina.getAccount(address, TokenId.default);
account = Mina.getAccount(address, tokenId);
} else {
({ account } = await fetchAccount({
publicKey: address,
tokenId: TokenId.toBase58(TokenId.default),
tokenId: TokenId.toBase58(tokenId),
}));
}
if (account === undefined) return undefined;
Expand Down
Loading