-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GitHub Actions Workflows for Improved CI/CD Performance #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinMinkov
force-pushed
the
feat/speed-up-ci
branch
2 times, most recently
from
July 16, 2024 22:27
69e71f9
to
e371d0a
Compare
MartinMinkov
changed the title
Test: see if running unit tests in parallel is faster in ci
Test: Exploratory Implementation of Parallel Unit Tests in CI
Jul 16, 2024
MartinMinkov
force-pushed
the
feat/speed-up-ci
branch
6 times, most recently
from
July 17, 2024 23:06
a7c7d95
to
7865905
Compare
MartinMinkov
changed the title
Test: Exploratory Implementation of Parallel Unit Tests in CI
Add and Refactor GitHub Actions for Unit Tests Execution
Jul 17, 2024
MartinMinkov
changed the title
Add and Refactor GitHub Actions for Unit Tests Execution
Refactor GitHub Actions Workflows for Improved CI/CD Performance
Jul 17, 2024
MartinMinkov
force-pushed
the
feat/speed-up-ci
branch
from
July 17, 2024 23:20
1db2089
to
659f895
Compare
MartinMinkov
force-pushed
the
feat/speed-up-ci
branch
from
July 17, 2024 23:45
659f895
to
6da2b1e
Compare
…ced caching - Introduced a `Prepare` job to set up the repository, cache dependencies, count unit tests, and calculate chunks for parallel execution. - Updated `Build-And-Test-Server` job to restore repository and dependencies from cache, run integration tests, and add results to the job summary. - Added `Run-Unit-Tests` job to execute unit tests in parallel chunks, upload test results, and add them to the job summary. - Enhanced `Build-And-Test-Web` job to cache Playwright browsers, run end-to-end tests, and upload E2E test artifacts. - Refined `Release-on-NPM` and `Release-mina-signer-on-NPM` jobs to build and publish the project if the version has changed.
MartinMinkov
force-pushed
the
feat/speed-up-ci
branch
from
July 18, 2024 03:08
6da2b1e
to
53dae5f
Compare
MartinMinkov
force-pushed
the
feat/speed-up-ci
branch
from
July 18, 2024 15:59
e618e96
to
3b2befa
Compare
The unit tests have been removed from the CI test script. This change was likely made because the unit tests are now being run separately or have been moved to a different part of the CI pipeline. Removing them from this script helps to keep the CI process more focused and efficient.
MartinMinkov
force-pushed
the
feat/speed-up-ci
branch
from
July 18, 2024 16:11
3b2befa
to
279478b
Compare
…to run after all unit tests have completed successfully refactor(build-action.yml): make Build-And-Test-Web job depend on Prepare job instead of directly on unit tests for better separation of concerns and maintainability
shimkiv
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From PR description:
Enhanced Build-And-Test-Web Job:
...
Uploads E2E test artifacts.
Not a big deal, but I think it was always the case (uploading).
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the GitHub Actions workflows to improve the CI/CD pipeline performance for o1js by introducing parallel testing and optimized caching strategies.
All CI tests now take around
1h
, down from around3h
, a 3x speed up!Key Changes:
New Prepare Job:
Updated Build-And-Test-Server Job:
New Run-Unit-Tests Job:
Enhanced Build-And-Test-Web Job:
Benefits:
Additional Work