Implements AND gadget #1193
Implements AND gadget #1193
Conversation
jackryanservia
requested review from
Trivo25,
MartinMinkov and
ymekuria
and removed request for
a team and
mitschabaude
src/lib/gates.ts
Outdated
| @@ -81,6 +81,22 @@ function xor( | |||
| ); | |||
| } | |||
|
|
|||
| /** | |||
| * Generic gate | |||
There was a problem hiding this comment.
It's great that you expose this, but I think it could use a bit of polishing:
- instead of
FieldConst, this should takebigintand convert them so that it's more natural to use from o1js (I'd considerFieldConsta purely internal type which exists for OCaml compatibility, but really represents a bigint modulo the field size) - The doccomment should say what constraint is added by the generic gate:
sl*l + sr*r + so*o + sm*l*r + sc === 0
- We should make the function signature as unconfusing as possible. Currently, it's 8 inputs only documented by 1- or 2-letter vars, which is just unreadable (see the code where you used this gate).
Suggestion: You could make the input consist of two separate objects: the constant coefficients/selectors, and the input variables. Then in each of those objects the keys provide a degree of self-explanation
function generic(
coefficients: { left: bigint, right: bigint, out: bigint, mul: bigint, const: bigint },
inputs: { left: Field, right: Field, out: Field }
)This is just a suggestion, feel free to modify to your preference - the main point is that the function signature should be easy to use
| generic( | ||
| sl: FieldConst, | ||
| l: FieldVar, | ||
| sr: FieldConst, | ||
| r: FieldVar, | ||
| so: FieldConst, | ||
| o: FieldVar, | ||
| sm: FieldConst, | ||
| sc: FieldConst | ||
| ): void; |
There was a problem hiding this comment.
I made the generic interface more friendly in TS and left the OCaml side as is (so that everything matches basic).
Let me know if you would like me to change anything more (e.g., have OCaml use the same interface, or just rename these variables).
There was a problem hiding this comment.
I think it's perfect!
| ); | ||
|
|
||
| // compute values for gate | ||
| // explanation: https://o1-labs.github.io/proof-systems/specs/kimchi.html?highlight=gates#and |
There was a problem hiding this comment.
Should this line be removed?
There was a problem hiding this comment.
I think it's valuable!
| * [Generic gate](https://o1-labs.github.io/proof-systems/specs/kimchi.html?highlight=foreignfield#double-generic-gate) | ||
| * The vanilla PLONK gate that allows us to do operations like: | ||
| * * addition of two registers (into an output register) | ||
| * * multiplication of two registers | ||
| * * equality of a register with a constant | ||
| * | ||
| * More generally, the generic gate controls the coefficients (denoted `c_`) in the equation: |
Summary
This PR adds the implementation for the AND gadget to the existing Gadgets namespace, which behaves similarly to the
&operator in JavaScript.Context
The AND gadget does not require a new custom gate. Instead, it uses the XOR gate and one generic gate. See OCaml implementation for context.
Tested
This PR adds e2e tests, unit tests, and verification key tests for the AND gate.
Basic gate PR in o1js (required for this PR): o1-labs/o1js-bindings#190
closes: #1140