Merge pull request #1080 from o1-labs/live-test-upd

Container logging improvements and logs publishing.
o1-labs · Aug 21, 2023 · 59e0d75 · 59e0d75
2 parents 4f437aa + 77390d9
commit 59e0d75
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 12 deletions.
diff --git a/.github/actions/live-tests-shared/action.yml b/.github/actions/live-tests-shared/action.yml
@@ -1,5 +1,9 @@
 name: "Shared steps for live testing jobs"
 description: "Shared steps for live testing jobs"
+inputs:
+  mina-branch-name:
+    description: "Mina branch name in use by service container"
+    required: true
 runs:
   using: "composite"
   steps:
@@ -26,3 +30,10 @@ runs:
         sh run-ci-tests.sh
         cat profiling.md >> $GITHUB_STEP_SUMMARY
       shell: bash
+    - name: Upload Mina logs
+      uses: actions/upload-artifact@v3
+      with:
+        if-no-files-found: ignore
+        name: mina-logs-${{ inputs.mina-branch-name }}
+        path: /tmp/*.log
+        retention-days: 5
diff --git a/.github/workflows/live-tests.yml b/.github/workflows/live-tests.yml
@@ -28,15 +28,15 @@ jobs:
           - 5432:5432
           - 8080:8080
           - 8181:8181
-        # TODO: Disable logging for container as the workaround of long post-job-cleanup phase
-        # - Will be fixed by improving logging as part of the work on:
-        # - https://hub.docker.com/r/o1labs/mina-local-network
-        options: --log-driver=none
+        volumes:
+          - /tmp:/root/logs
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v3
       - name: Use shared steps for live testing jobs
         uses: ./.github/actions/live-tests-shared
+        with:
+          mina-branch-name: rampup
 
   berkeley-branch:
     timeout-minutes: 25
@@ -53,15 +53,15 @@ jobs:
           - 5432:5432
           - 8080:8080
           - 8181:8181
-        # TODO: Disable logging for container as the workaround of long post-job-cleanup phase
-        # - Will be fixed by improving logging as part of the work on:
-        # - https://hub.docker.com/r/o1labs/mina-local-network
-        options: --log-driver=none
+        volumes:
+          - /tmp:/root/logs
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v3
       - name: Use shared steps for live testing jobs
         uses: ./.github/actions/live-tests-shared
+        with:
+          mina-branch-name: berkeley
 
   develop-branch:
     timeout-minutes: 25
@@ -78,12 +78,12 @@ jobs:
           - 5432:5432
           - 8080:8080
           - 8181:8181
-        # TODO: Disable logging for container as the workaround of long post-job-cleanup phase
-        # - Will be fixed by improving logging as part of the work on:
-        # - https://hub.docker.com/r/o1labs/mina-local-network
-        options: --log-driver=none
+        volumes:
+          - /tmp:/root/logs
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v3
       - name: Use shared steps for live testing jobs
         uses: ./.github/actions/live-tests-shared
+        with:
+          mina-branch-name: develop