Skip to content

Commit

Permalink
Merge pull request #162 from nzzdev/release-3.1.5
Browse files Browse the repository at this point in the history
Release 3.1.5
  • Loading branch information
romankaravia authored Nov 4, 2019
2 parents fe2eae4 + 42389d7 commit 4a5f102
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 11 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Q-chart [![Build Status](https://travis-ci.com/nzzdev/Q-chart.svg?branch=dev)](https://travis-ci.com/nzzdev/Q-chart) [![Greenkeeper badge](https://badges.greenkeeper.io/nzzdev/Q-chart.svg)](https://greenkeeper.io/)

**maintainer**: [benib](https://github.com/benib)
**maintainer**: [romankaravia](https://github.com/romankaravia)

Q chart is a charting tool based on [Vega](https://github.com/vega/vega) for [Q](https://q.tools)

Expand Down
6 changes: 2 additions & 4 deletions chartTypes/commonMappings.js
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,7 @@ function getColumnAreaPrognosisMappings() {
transform: [
{
type: "filter",
expr:
"timeFormat(datum.xValue, '%Q') >= timeFormat(prognosisStartDate, '%Q')"
expr: "datum.xValue >= prognosisStartDate"
}
]
});
Expand Down Expand Up @@ -226,8 +225,7 @@ function getBarPrognosisMappings() {
transform: [
{
type: "filter",
expr:
"timeFormat(datum.xValue, '%Q') >= timeFormat(prognosisStartDate, '%Q')"
expr: "datum.xValue >= prognosisStartDate"
}
]
});
Expand Down
6 changes: 2 additions & 4 deletions chartTypes/line/mapping.js
Original file line number Diff line number Diff line change
Expand Up @@ -240,13 +240,11 @@ module.exports = function getMappings() {
// split the marks at the prognosisStart index
const lineMark = clone(spec.marks[0].marks[0]);
lineMark.encode.enter.defined = {
signal:
"datum.yValue !== null && timeFormat(datum.xValue, '%Q') <= timeFormat(prognosisStartDate, '%Q')"
signal: "datum.yValue !== null && datum.xValue <= prognosisStartDate"
};
const lineMarkPrognosis = clone(spec.marks[0].marks[0]);
lineMarkPrognosis.encode.enter.defined = {
signal:
"datum.yValue !== null && timeFormat(datum.xValue, '%Q') >= timeFormat(prognosisStartDate, '%Q')"
signal: "datum.yValue !== null && datum.xValue >= prognosisStartDate"
};
lineMarkPrognosis.style = "prognosisLine";
spec.marks[0].marks = [lineMark, lineMarkPrognosis];
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "q-chart",
"version": "3.1.4",
"version": "3.1.5",
"description": "",
"main": "index.js",
"scripts": {
Expand Down

0 comments on commit 4a5f102

Please sign in to comment.