Merge pull request #258 from nzzdev/release-3.8.0

Release 3.8.0

README.md

@@ -4,6 +4,10 @@
 
 Q chart is a charting tool based on [Vega](https://github.com/vega/vega) for [Q](https://q.tools)
 
+## Important Notices
+
+- Do not update vega above 5.21 unless this oustanding [bug](https://github.com/vega/vega/issues/3451) is fixed and all test pass after updating.
+
 ## Table of contents
 
 - [Installation](#installation)

chartTypes/line/mapping.js

@@ -176,6 +176,19 @@ module.exports = function getMappings() {
         }
       },
     },
+    {
+      path: "item.options.lineChartOptions.yScaleType",
+      mapToSpec: function (yScaleType, spec) {
+        objectPath.set(spec, "scales.1.type", yScaleType);
+
+        // Log scales must have a min value that is non-zero.
+        // If no minValue is set for the y-axis we will set it to 1 here,
+        // otherwise the linechart will be misdrawn and the user will be confused.
+        if (spec.scales[1].domainMin === undefined) {
+          objectPath.set(spec, "scales.1.domainMin", 1);
+        }
+      },
+    },
     {
       path: "item.options.lineChartOptions.minValue",
       mapToSpec: function (minValue, spec, mappingData) {
@@ -212,6 +225,20 @@ module.exports = function getMappings() {
         objectPath.set(spec, "scales.1.domainMax", maxValue / divisor);
       },
     },
+    {
+      // This is currently turned off in the frontend because for some reason vega still
+      // does some processing over the values and does not show the exact values we define.
+      path: "item.options.lineChartOptions.yAxisTicks",
+      mapToSpec: function (values, spec, mappingData) {
+        if (values.length === 0) {
+          values = undefined;
+        } else {
+          values = values.split(",");
+        }
+
+        objectPath.set(spec, "axes.1.values", values);
+      }
+    },
     {
       path: "item.options.lineChartOptions.reverseYScale",
       mapToSpec: function (reverseYScale, spec) {