Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests, code formatting, tests in pipeline #5

Merged
merged 13 commits into from
Jun 27, 2024
Merged

Improve tests, code formatting, tests in pipeline #5

merged 13 commits into from
Jun 27, 2024

Conversation

dnzbk
Copy link
Collaborator

@dnzbk dnzbk commented Jun 27, 2024

Description

  • fixed a UnicodeEncodeError exception that occurs when using special characters in names;
  • updated pipeline, docs;
  • improved tests;
  • formatted the code using Black.

Testing

  • Windows 10/NZBGet 24.2

@dnzbk dnzbk requested a review from phnzb June 27, 2024 14:22
@dnzbk dnzbk changed the title Add: improve tests, linter Improve tests, code formatting, tests in pipeline Jun 27, 2024
phnzb
phnzb requested changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@phnzb phnzb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error in workflow - please fix

.github/workflows/tests.yml Outdated Show resolved Hide resolved
phnzb
phnzb previously approved these changes Jun 27, 2024
View reviewed changes
@dnzbk dnzbk merged commit 4086716 into main Jun 27, 2024
2 checks passed
@dnzbk dnzbk deleted the feature/tests branch June 27, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phnzb phnzb phnzb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnzbk @phnzb