[Product Data] Introduce data persistence on gateways #5022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonwicky
force-pushed
the
simon/gateway_stats_persistence
branch
from
8eafcbf
to
1a4a22a
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
jstuczyn
reviewed
Oct 24, 2024
common/gateway-stats-storage/migrations/20241017120000_create_initial_tables.sql
Outdated
Show resolved
Hide resolved
common/gateway-stats-storage/migrations/20241017120000_create_initial_tables.sql
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR builds on top of #4974, not changing the behavior of the data collection, but persisting them in a sqlite database so they can be kept across restarts and crashes.
It also leave the door open for other stats module to use that storage if needed.
Points of Interest
gateway_stats_storagecratestatisticsmodule to account the new storage systemThis change is