Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mixnode] replace rocket with axum #4071

Merged
merged 3 commits into from
Oct 30, 2023
Merged

[mixnode] replace rocket with axum #4071

merged 3 commits into from
Oct 30, 2023

Conversation

jstuczyn
Copy link
Contributor

Description

This is mostly a clean up PR that replaces rocket in our mixnode http api with axum.
It's also the first step towards #4070 as it will allow us to combine the routes under the single server.

testing remarks:

all the routes, i.e. /verloc, /stats, /stats?debug=true, /description and /hardware should work EXACTLY the same as they did before

@jstuczyn jstuczyn self-assigned this Oct 27, 2023
@jstuczyn jstuczyn added this to the Galaxy milestone Oct 27, 2023
@jstuczyn jstuczyn mentioned this pull request Oct 30, 2023
Merged
@jstuczyn jstuczyn merged commit da9d743 into develop Oct 30, 2023
20 checks passed
@jstuczyn jstuczyn deleted the chore/mixnode-axum branch October 30, 2023 12:55
benedettadavico added a commit that referenced this pull request Nov 7, 2023
@benedettadavico @mfahampshire
@serinko @octol @jstuczyn @raphael-walther @tommyv1987 @sebastinez @mmsinclair
Merging Release/2023.4-galaxy (#4111)
e6652b2 
* added info on post_process.sh

* added new pages

* added new pages to summary

* added new examples pages

* update plugin

* stripped down + added new links

* added deprecation warning

* smol reword

* initialise operators update branch

* update smoosh faq - two options

* update smoosh faq - two options

* correction based on feedback

* correction based on feedback

* update exit policy info

* create legal region pages - us, swiss

* add legal findings switzerland

* add regions to SUMMARY.md

* add regions to SUMMARY.md

* syntax fix

* syntax fix

* add page license

* syntax fix

* fix based on feedback

* Run embedded ip-forwarder in gateway

* config handling

* rustfmt

* Fix test compilation

* Remove hack

* Proper config backwards compatibility

* [mixnode] replace rocket with axum (#4071)

* axum-equivalent mixnode http api routes

* replaced all rocket routes with axum equivalents

* removed '_axum' suffix from the routes

* No need to show setup-ip-forwarder just yet

* Update security disclosure process

* unified native, socks5, NR client inits

* combine client run args

* moved to different submodule

* putting no cover and fastmode to common args

* removed the contracicting flag

* Incorporate basic nym-node HTTP API (with swagger) to mixnodes (#4075)

* basic nym-node router

* loading legacy routes

* dead code

* config migrations

* wasm lock

* Rename to old_config_v1_1_31.rs

* Update files to reflect new filename

* Rename to nym-ip-packet-router

* Rename to ip-packet-router directory

* Fix missed rename in template

* add exit policy implementation steps

* add exit policy implementation steps

* syntax fix

* Big chunk of search replace to the new name

* rustfmt

* add exit policy implementation steps

* ci: add workflow_dispatch to ci-nym-vpn-ui-rust

* Set name to ci-nym-api-tests

* replaced '--disable-sign-ext' with '--signext-lowering' when running wasm-opt (#3896)

* replaced '--disable-sign-ext' with '--signext-lowering' when running wasm-opt + updated wasm-opt

* updated wasm-opt used in CI

* ci: iterate on ci-nym-vpn-ui-rust

* ci: more iterate on ci-nym-vpn-ui-rust

* ci: tidy ci-nym-vpn-ui-js

* added examples pages

* added notepad to gitignore file

* added community examples

* streamline integrations files

* streamlined node types

* add token economics paper info

* added shipyard info

* try change ifconfig.me -> icanhazip.com

* tweak

* Add nodejs wrapper for wasm sphynx client

* Add mix-fetch for nodejs

* Add hack for working with old nym gateways

Signed-off-by: Sebastian Martinez <[email protected]>

* Polishing nodejs-client and mix-fetch-node

Signed-off-by: Sebastian Martinez <[email protected]>

* add --with-exit-policy flag

* change --host -> 146.70.170.3

* syntax fix

* change --host to -4 https://ifconfig.me

* print info on exit policy on embedded NR init (#4086)

* ci: rename to ci-binary-config-checker

* ci: rename cd-docs

* ci: move nightly to ubuntu-20.04

* ci: sort out nightly wallet build

* ci: nightly-build sed debug = false

* ci: use macos-latest in nightly-build

* ci: create nightly-nym-connect-desktop-build

* finish exit gateway setup

* Revert "Add hack for working with old nym gateways"

This reverts commit 7129de4.
To avoid breaking wss

* add example setup-network-requester

* fix: adding some polyfills to nodejs-client and mix-fetch

During the merge of the nodejs-wasm-client there seems to be some
losses, this commit makes nodejs-client and the nodejs mix-fetch work
with the internal tools. Still looking into Tommys qa feedback.

* spellcheck + table format fix

* Fix the getRandomValue crypto polyfill issue

Signed-off-by: Sebastian Martinez <[email protected]>

* Update mix-fetch-node to rc.3

Signed-off-by: Sebastian Martinez <[email protected]>

* add wss host setup

* new directory structure for rust SDK docs

* first draft of expanded rust stuff

* ci: fix typo in workflow name

* ci: switch nightly-build to github hosted windows-latest

* remove ./ from SUMMARY.md

* change syntax *binary* ->

* change phrasing

* change phrasing

* add correct cmdrun auto flow

* add reversed proxy ports

* tweak

* fixed broken link

* admonish plugin upgrade

* fix broken imports

* tweak

* updated import info

* removed todo - checked dependency versioning

* ci: change nightly-nym-wallet-build to windows-latest

* ci: switch nightly-nym-connect-desktop-build to windows-latest

* add smoosh link to intro

* first pass at troubleshooting doc

* first pass at helper messages

* Github Actions: fix cd-docs

* Github actions: remove deployment to website-dev

* Update Cargo.lock

* upgraded mdbook-admonish version

* added code example to helpers

* revert previous

* Fix sdk publish action (#4088)

* fix: sdk publish script

The bash implementation used in the GitHub CI runner seems to have an
issue with incrementing a variable with `(( COUNTER++ ))` while `((
COUNTER=+1 ))` works fine.

* Add more sdk packages to workspace and normalize build sdk scripts

* Disable workspaces in npm publish sdk

Signed-off-by: Sebastian Martinez <[email protected]>

* Continue publishing even when it fails

Signed-off-by: Sebastian Martinez <[email protected]>

---------

Signed-off-by: Sebastian Martinez <[email protected]>

* Add NodeJS mixFetch to version bump tool

* Update SDK contract client

* Release Typescript SDK to version 1.2.1

* Fix lint error

* Fix lint error

* added open proxies

* fixed addr

* ci: cargo clean before clippy in nightly build

* Create IpForwarderService

* on_message

* Rename remaining places to ip packet router

* send back to mixnet

* rustfmt

* Add RoutingMode enum

* rustfmt

* Take RoutingMode as argument

* NYM_CLIENT_ADDR

* Fix compilation on non-linux

* Remove expect on NYM_CLIENT_ADDR

* updated mdbook admonish assets

* install admonish to all books

* added links + typo fixes

* add exit policy to existing NR

* Bump mixnode version and update changelog

---------

Signed-off-by: Sebastian Martinez <[email protected]>
Co-authored-by: mfahampshire <[email protected]>
Co-authored-by: serinko <[email protected]>
Co-authored-by: Jon Häggblad <[email protected]>
Co-authored-by: Jędrzej Stuczyński <[email protected]>
Co-authored-by: Raphaël Walther <[email protected]>
Co-authored-by: Raphaël Walther <[email protected]>
Co-authored-by: Tommy Verrall <[email protected]>
Co-authored-by: Sebastian Martinez <[email protected]>
Co-authored-by: mfahampshire <[email protected]>
Co-authored-by: Mark Sinclair <[email protected]>
Co-authored-by: mx <[email protected]>
@benedettadavico benedettadavico mentioned this pull request Nov 7, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benedettadavico benedettadavico benedettadavico approved these changes

Assignees

@jstuczyn jstuczyn

Labels
None yet
Projects
None yet
Milestone
Galaxy
Development

Successfully merging this pull request may close these issues.
2 participants
@jstuczyn @benedettadavico