Create IpPacketRouter #4068
Merged
Create IpPacketRouter #4068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstuczyn
reviewed
Oct 27, 2023
| @@ -123,7 +123,7 @@ impl TunDevice { | |||
|
|
|||
| // This is how wireguard does it, by consulting the AllowedIPs table. | |||
| if false { | |||
| let peers = self.peers_by_ip.lock().await; | |||
| let peers = self.peers_by_ip.as_ref().unwrap().lock().await; | |||
There was a problem hiding this comment.
if you're just always unwrapping it, what's the point of wrapping it in an option in the first place?
There was a problem hiding this comment.
Well this is draft so ... ;)
Hold your horses
There was a problem hiding this comment.
There we go, no more unwrap :)
octol
force-pushed
the
jon/embedded-ip-forwarder-in-gateway
branch
from
6daca7f
to
49cf33f
Compare
Base automatically changed from
jon/embedded-ip-forwarder-in-gateway
to
develop
October 31, 2023 13:48
octol
force-pushed
the
jon/ip-forwarder-tun-device
branch
from
a955ef8
to
f39ffc7
Compare
octol
force-pushed
the
jon/ip-forwarder-tun-device
branch
from
0490762
to
6052a9e
Compare
octol
force-pushed
the
jon/ip-forwarder-tun-device
branch
from
c8d7705
to
756aca3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create IpPacketRouter