-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/exit policy #4030
Merged
Merged
Feature/exit policy #4030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstuczyn
force-pushed
the
feature/exit-policy
branch
from
October 25, 2023 10:10
d1c71cd
to
b7d4d3d
Compare
jstuczyn
force-pushed
the
feature/exit-policy
branch
from
October 25, 2023 10:34
5ad8e1f
to
427cb1f
Compare
benedettadavico
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #4024
Apart from obviously testing the thing, before it can be merged, we need to make sure the following is adjusted to the correct value (i.e. we need to redeploy the website):
nym/common/network-defaults/src/mainnet.rs
Line 31 in 86fcb51
edit 25/10/23: it was already updated
what does it do?
as the related ticket describes, it adds a different kind of request filtering to our network requesters. rather than being based on the current allow lists system, it uses a tornull-based exit policy.
right now this is enabled via the
with-exit-policy
flag (or obviously also via modifyingconfig.toml
file), however, soon this will get deprecated and the exit policy will become the default. even further in the future, the allow-list will be completely removed and NRs will all be exclusively running the exit policy.to see whether particular NR uses the exit policy (and what entires it has there) you can do one of the following:
/api/v1/network-requester/exit-policy
endpoint on the nym-node HTTP APIcargo run -- -c ../../envs/sandbox.env --provider <provider-address> exit-policy
finally, @tommyv1987 @benedettadavico when testing you can set the
EXIT_POLICY
environmental variable to any endpoint serving a valid policy file. For my local tests I've just had a dummysample_policy
served withpython -m http.server 8001
for the 'real' deployment file, that we will use in mainnet, you can see it here: https://github.com/nymtech/nym-websites/pull/88#issuecomment-1772577284
Checklist:
CHANGELOG.md