Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable http api port to gateway #4016

Closed
wants to merge 2 commits into from

Conversation

neacsu
Copy link
Contributor

@neacsu neacsu commented Oct 18, 2023

No description provided.

@neacsu neacsu requested a review from durch October 18, 2023 09:49
@jstuczyn
Copy link
Contributor

i imagine this will most likely get superseded by #3970 once merged.
we'll want to have gateways/nym-nodes expose their API on one of predefined ports: 80/443 if properly setup with SSL (which will be obligatory down the line), or 8080 otherwise; so there's going to be no need to put anything in the contract

@neacsu
Copy link
Contributor Author

neacsu commented Oct 18, 2023

i imagine this will most likely get superseded by #3970 once merged. we'll want to have gateways/nym-nodes expose their API on one of predefined ports: 80/443 if properly setup with SSL (which will be obligatory down the line), or 8080 otherwise; so there's going to be no need to put anything in the contract

Given that, from what I last heard, it's not clear if we will have these ports on the gateway, or in a reverse proxy, having it configurable should still be ok.

@neacsu neacsu requested review from octol and jstuczyn October 18, 2023 10:31
@jstuczyn
Copy link
Contributor

i imagine this will most likely get superseded by #3970 once merged. we'll want to have gateways/nym-nodes expose their API on one of predefined ports: 80/443 if properly setup with SSL (which will be obligatory down the line), or 8080 otherwise; so there's going to be no need to put anything in the contract

Given that, from what I last heard, it's not clear if we will have these ports on the gateway, or in a reverse proxy, having it configurable should still be ok.

I think we should sync up with @mmsinclair on his current thoughts about that. because afaik we didn't want to put yet more data in the contract and nodes should have been using predictable ports. obviously, if operators wanted, they could set custom ports locally and expose the correct ones via proxy (but that's already covered by my feature)

@neacsu
Copy link
Contributor Author

neacsu commented Oct 18, 2023

Ok, I'll close this PR then, as the customisable port will already be covered by another PR.

@neacsu neacsu closed this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants