test: Improve minimal init, test launching #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that the tests for Neovim |
|
I am having difficulties replicating the test failure for |
|
Seems good now, the last change was only because I caught some caching in the workflow that may have been missed prior to that commit with my changes. Not sure why |
kristijanhusak
requested changes
Sep 26, 2023
kristijanhusak
requested changes
Sep 26, 2023
PriceHiller
force-pushed
the
test/minimal_init_improvements
branch
3 times, most recently
from
9c28651
to
cc99dff
Compare
|
Those "4 commits" are rebases over previous commits to address the previous comments while keeping the git history clean as a heads up. |
This ensures that any caching that may occur between these works properly so we aren't checking these repositories out twice. The minimal init will not checkout if those dependencies exist at the correct path.
PriceHiller
force-pushed
the
test/minimal_init_improvements
branch
from
9386863
to
703481c
Compare
|
*6 commits now :/ Missed the CI checkout for the deps. I haven't found anything else, unless you find something I think (see hope) this is good to go. |
kristijanhusak
requested changes
Sep 26, 2023
We now download these deps as part of the minimal init
kristijanhusak
approved these changes
Sep 26, 2023
SlayerOfTheBad
pushed a commit
to SlayerOfTheBad/orgmode
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! This PR "luafies" the tests and removes the need to
git clonetest dependencies ahead of time by doing the clone process in the minimal init.git cloneany test dependencies, instead the minimal init handles that for you.rm -rfto clean up after itself. I know there's a bit of a push to get better windows support. I noticed the issues and I think I may have a solution in another PR. If therm -rfdoesn't run it's not a big deal for now.tesfilecommand and instead allowed a testfile to be specified for themake testcommand and if one is not found it fallbacks to tests/plenaryFILE=./tests/plenary/util_spec.lua make testfor instance 😉.I know there weren't any open issues for this, but I found it slightly annoying to have to run
git clonebefore doing any testing. If this PR is undesired feel free to reject it.