Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add luarocks bin directory to the Neovim path #153

Merged
merged 5 commits into from
Feb 17, 2024
Merged

Conversation

vhyrro
Copy link
Collaborator

@vhyrro vhyrro commented Feb 17, 2024

This PR allows any plugin running under a Neovim instance with rocks.nvim to gain access to whatever binaries are installed under .local/share/nvim/rocks/bin/. This may come in super handy for rocks which publish binaries (wink wink) :)

Copy link
Contributor

github-actions bot commented Feb 17, 2024

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

@vhyrro
Copy link
Collaborator Author

vhyrro commented Feb 17, 2024

I found the end of config.lua to the best place to put the path expansion logic. Two questions:

  • We should probably prepend the bin path instead of append to give it a higher priority, right? Done that.
  • Should I move it from config.lua to somewhere else?

(cc @mrcjkb)

@vhyrro
Copy link
Collaborator Author

vhyrro commented Feb 17, 2024

Nevermind, for some reason I thought Windows also uses : as its path separator. It actually uses a semicolon - thanks, windows.

@vhyrro
Copy link
Collaborator Author

vhyrro commented Feb 17, 2024

Added hisham's very recent sysdetect rock to rocks. This will ensure that we're using the correct path separator everywhere hopefully :)

@vhyrro
Copy link
Collaborator Author

vhyrro commented Feb 17, 2024

image
Hmm...

@mrcjkb
Copy link
Member

mrcjkb commented Feb 17, 2024

image Hmm...

The nix build is sandboxed. We'll probably have to package sysdetect and add it to the nix build inputs.
I'll look into it later today

@mrcjkb
Copy link
Member

mrcjkb commented Feb 17, 2024

I found the end of config.lua to the best place to put the path expansion logic. Two questions:

  • We should probably prepend the bin path instead of append to give it a higher priority, right? Done that.
  • Should I move it from config.lua to somewhere else?

(cc @mrcjkb)

How about plugin/rocks.lua?

@vhyrro
Copy link
Collaborator Author

vhyrro commented Feb 17, 2024

Fixed now!

@vhyrro vhyrro merged commit 13c2103 into master Feb 17, 2024
6 checks passed
@vhyrro vhyrro deleted the add-binaries branch February 17, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants