Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(luarocks): make sure LUAROCKS_CONFIG is unset #150

Merged
merged 2 commits into from
Feb 16, 2024
Merged

fix(luarocks): make sure LUAROCKS_CONFIG is unset #150

merged 2 commits into from
Feb 16, 2024

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Feb 16, 2024

Fixes #149

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 16, 2024 •
edited by mrcjkb
Loading

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

@mrcjkb
Copy link
Member Author

mrcjkb commented Feb 16, 2024

Merging, as this is trivial.

@mrcjkb mrcjkb enabled auto-merge (squash) February 16, 2024 16:45
@mrcjkb mrcjkb merged commit 8cfb41b into master Feb 16, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Feb 16, 2024
Merged
@mrcjkb mrcjkb deleted the fix-luarocks-config branch February 16, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto Awaiting requested review from teto

@NTBBloodbath NTBBloodbath Awaiting requested review from NTBBloodbath NTBBloodbath is a code owner

@vhyrro vhyrro Awaiting requested review from vhyrro vhyrro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] If LUAROCKS_CONFIG is set, it will override rocks.nvim's luarocks config
1 participant
@mrcjkb