Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installer): remove color seqence from shell output #130

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

pysan3
Copy link
Contributor

@pysan3 pysan3 commented Feb 1, 2024

Lua is not oxidized

("Cloning luarocks failed.\nstderr: {}\nstdout: {}"):format(sc.stderr, sc.stdout),

Lua has no mustache.
Replace all with %s.

Remove color sequences

But even if I replace all with %s, the error message is pretty difficult to read due to the color sequences in the output.

image

I've added a wrapper function to remove the color sequences for a better visibility.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

Copy link
Member

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks 🙏

@mrcjkb mrcjkb merged commit 6c6da2b into nvim-neorocks:master Feb 1, 2024
7 checks passed
@pysan3 pysan3 deleted the fix-shell-output branch February 1, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants