[Feature/Fix]: - [Feat]: Allow to change the value of sign column in focused window from any buffer, bring exclude filetypes, buftypes comback - [Fix]: Prevent sign column from updating when buffer is disabled when buffer enter or out #113
Conversation
sontungexpt
changed the title
|
Thank you very much for your contribution! Please create one PR for each feature. Don't combine them, so it is easier to comment. All PRs should include tests to make sure your feature works correctly and will not brake when someone else changes some part of the code. So please add tests! |
lua/focus/modules/autocmd.lua
Outdated
| ) | ||
| end | ||
|
|
||
| if #config.exclude.bufnames > 0 then |
There was a problem hiding this comment.
I don't think buffer names should be included here. That's too specific, almost definitely better handled by an autocmd in the user's config
|
Please split up the PR, fixes in their own PR and features in another or this one ... |
@sontungexpt it's likely that some of these features will be cherry picked / not all added at once, and as cryptomilk said it's easier to review with isolated changes. If you could split the changes into separate PRs (i.e. filetype/buftype in one PR, sign column fix in another, etc.) that would be super helpful. Thanks! Also, try to keep the style compliant to the provided |
The first commit adds a new feature that allows users to change the value of the sign column in the focused window from auto to yes
The second commit fixes a bug that caused the sign column to update even when leave bufer but that buffer is disabled . Please review and merge these changes.
The third and fourth commit bring exclude filetypes comback