Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add compatibility with hable #1025

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix: add compatibility with hable #1025

merged 1 commit into from
Dec 21, 2023

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Dec 18, 2023

πŸ”— Linked issue

#1000

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

In the case of hable, since the hook does not return a function, an error is output when executing nuxt.callHook('restart').

unsub is not a function

In nuxt 2.17.3, it is migrated to hookable, so maybe this support is not needed.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx marked this pull request as ready for review December 21, 2023 13:14
@wattanx wattanx requested a review from danielroe December 21, 2023 13:15
@danielroe danielroe merged commit 1fa3dce into main Dec 21, 2023
9 checks passed
@danielroe danielroe deleted the fix/fix-hook-once-mock branch December 21, 2023 20:18
@github-actions github-actions bot mentioned this pull request Dec 19, 2023
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants