fix: comments being treated as errors #152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Fixing this was easier than opening an issue π
β Type of change
π Description
This PR prevents the module from treating comments as errors and logging them to the console.
I looked into pushing the comments to
currentGroup.comments.push(comment)
to later restore them but, as mentioned in your comment (comments are too hard to parse in a logical order, we'll just omit them
), it makes things unnecessarily complicated and would require rewriting other parts of the module. Plus I would count getting rid of them as minification so I'm guessing it's a good thing.I believe we can get rid of
currentGroup.comment
and thefor
loop where we restore the comments since we're not saving them at any point. Might have a very minor positive impact on sites with a bigrobots.txt
file.