Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add prettier to dev deps #181

Merged
merged 6 commits into from
Mar 26, 2024
Merged

✨ add prettier to dev deps #181

merged 6 commits into from
Mar 26, 2024

Conversation

AucaCoyan
Copy link
Contributor

@AucaCoyan AucaCoyan commented Mar 26, 2024

Fixes #180

I left only the relevant changes. When this is reviewed and it's okay, I'll make one commit formatting everything.

As for configs I have:

  • use ' instead of default "
  • end of line default: lf

@AucaCoyan
Copy link
Contributor Author

I'll mark it ready for review, but don't merge it yet! (it's pending the format, which pollutes the review with a lot of changes)

@AucaCoyan AucaCoyan marked this pull request as ready for review March 26, 2024 19:49
@fdncred
Copy link
Collaborator

fdncred commented Mar 26, 2024

ok, lemme know when you're ready to land it.

@AucaCoyan
Copy link
Contributor Author

Great! All the format passed and merged changes from main. Ready!

@fdncred fdncred merged commit 92faaf7 into nushell:main Mar 26, 2024
1 check passed
@fdncred
Copy link
Collaborator

fdncred commented Mar 26, 2024

Thanks

@AucaCoyan AucaCoyan deleted the add-prettier branch March 26, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use biomejs or prettier to format
2 participants