CwdAwareHinter: remove cwd filter when there are no results #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #656 +/- ##
==========================================
- Coverage 49.22% 49.15% -0.08%
==========================================
Files 43 43
Lines 7912 7924 +12
==========================================
Hits 3895 3895
- Misses 4017 4029 +12
|
|
As something to do later, maybe in another PR, it would be good to get rid of the expects like we discussed on discord. I'd like to see proper error handling on expects and unwraps in reedline if possible. But I'm not sure that should hold up this PR since reedline already has a collection of them. |
p00f
force-pushed
the
cwdawerehinter-fallback
branch
from
e8a48a8 to
4190932
Compare
p00f
force-pushed
the
cwdawerehinter-fallback
branch
from
4190932 to
658c71c
Compare
p00f
force-pushed
the
cwdawerehinter-fallback
branch
from
ba34d9c to
4765933
Compare
|
I just saw that the next nushell release is tomorrow so I wanted to get this in |
|
Tested it with the As we made it compulsory for the sqlite history let's get this qol improvement in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes nushell/nushell#10921