Also run clippy on examples (#666)

* Also run clippy on examples This PR also fixes existing clippy lints * Update .github/workflows/ci.yml --------- Co-authored-by: Stefan Holderbach <[email protected]>
nushell · Nov 14, 2023 · 63c43a9 · 63c43a9
1 parent d9e0a32
commit 63c43a9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -44,7 +44,7 @@ jobs:
         run: cargo fmt --all -- --check
 
       - name: Clippy
-        run: cargo clippy ${{ matrix.flags }} --all -- -D warnings
+        run: cargo clippy ${{ matrix.flags }} --all-targets --all -- -D warnings
 
 
       - name: Tests

diff --git a/examples/cwd_aware_hinter.rs b/examples/cwd_aware_hinter.rs
@@ -52,8 +52,8 @@ fn main() -> io::Result<()> {
     let home_dir = std::env::home_dir().unwrap();
 
     let history = create_filled_example_history(
-        &home_dir.to_string_lossy().to_string(),
-        &orig_dir.to_string_lossy().to_string(),
+        home_dir.to_string_lossy().as_ref(),
+        orig_dir.to_string_lossy().as_ref(),
     );
 
     let mut line_editor = Reedline::create()

diff --git a/examples/transient_prompt.rs b/examples/transient_prompt.rs
@@ -61,7 +61,7 @@ struct CustomValidator;
 
 impl Validator for CustomValidator {
     fn validate(&self, line: &str) -> ValidationResult {
-        if line.ends_with("\\") {
+        if line.ends_with('\\') {
             ValidationResult::Incomplete
         } else {
             ValidationResult::Complete